Misc SSD1327 and SSD1363 improvements #94316
Open
+31
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LUT table to rom instead of ram Signed-off-by: Camille BAUD <[email protected]>
josuah
previously approved these changes
Aug 11, 2025
british english -> american english Signed-off-by: Camille BAUD <[email protected]>
Model on ssd1327 Signed-off-by: Camille BAUD <[email protected]>
VynDragon
force-pushed
the
ssd1327_const
branch
from
ebcc8e3 to
4682641
Compare
josuah
previously approved these changes
Aug 11, 2025
JarmouniA
previously approved these changes
Aug 11, 2025
Yes #87921 (comment) |
kartben
requested changes
Aug 13, 2025
Comment on lines
+93
to
+97
| grayscale-enhancement: | ||
| type: boolean | ||
| description: Enable greyscale enhancement, undocumented. | ||
| description: Enable grayscale enhancement, undocumented. | ||
|
|
||
| greyscale-table: | ||
| grayscale-table: |
There was a problem hiding this comment.
change needs to be mentioned in migration guide as its requiring downstream users to make changes to their code
notice change of property name Signed-off-by: Camille BAUD <[email protected]>
VynDragon
force-pushed
the
ssd1327_const
branch
from
febd94a to
79ca58f
Compare
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
josuah
approved these changes
Aug 13, 2025
JarmouniA
approved these changes
Aug 13, 2025
kartben
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
greyscale -> grayscale
+const
ssd1363 lut -> ssd1327 style lut